fix(gateway): validate peer synchronization URLs - #932
Merged
Conversation
kvinwang
changed the title
kvinwang
force-pushed
the
codex/fix-gateway-peer-sync-urls
branch
from
August 4, 2026 15:25
ba59091 to
8c47ef1
Compare
kvinwang
changed the base branch from
codex/fix-gateway-dns-credential-storage
to
master
August 4, 2026 15:25
kvinwang
added a commit
that referenced
this pull request
Aug 5, 2026
…er-identity [STACKED on #932] fix(gateway): accept app-info peer identities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Peer synchronization URLs from persisted/configured gateway state were accepted without restricting scheme, credentials, or malformed host data. Synchronization could target an invalid or unintended endpoint and fail after state was committed.
Root cause and fix
Parse and validate peer URLs at the boundary, allowing only the supported secure form before storing or connecting.
Implementation
The branch records the following focused implementation work:
fix(gateway): validate peer synchronization URLsChanged paths:
dstack/gateway/src/kv/mod.rsScope
This PR addresses one logical
gatewayfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
This PR is based directly on
masterand has no parent dependency.Verification
git diff --check origin/master..origin/codex/fix-gateway-peer-sync-urls: passed.